fix(wallets): prevent duplicate Trezor wallets when using --hd-paths #12214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarmashAlex
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
grandizzy
approved these changes
Oct 24, 2025
Collaborator
grandizzy
left a comment
grandizzy
left a comment
There was a problem hiding this comment.
thank you, makes sense, logic is inline with ledger check here
foundry/crates/wallets/src/multi_wallet.rs
Lines 368 to 373 in ad627ae
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear mnemonic_indexes for Trezor when hd_paths are specified, mirroring Ledger behavior. This avoids creating both a path-derived wallet and an index 0 wallet due to the default_value on --mnemonic-indexes. Root cause: with default indexes present, the macro created wallets from both hd_paths and indexes, producing duplicates for Trezor.